Resolve "Python Linting"

See merge request oilgas/ltfs/fiphoboserver!28

Commit log:
* add yapf execution to formatting script
* run formatting script
* rename formatting and linting jobs
* install yapf in Format job

Resolve "Add Stress Test"

See merge request oilgas/ltfs/fiphoboserver!27

Change log:
* remove empty get file
* add function for PUT, GETMD GET with random key and get_file_name
* add stress test involving multiple parallel requests

General improvements

See merge request oilgas/ltfs/fiphoboserver!26

Change log:
* Dockerfile that inherits from an image with dependencies installed
* describe build process in README
* refer to superfiphoboserver in README
* rename m_file_closed to m_stream_completed
* formalise README

S3 error handling

See merge request oilgas/ltfs/fiphoboserver!23

Sophie Wenzel-Teuber authored Apr 08, 2020 and Aaron Dees committed Apr 08, 2020

All errors returned from phobos now have at least a little distinct error messages (as far as the return values permit it) and send an S3 readable XML along with the error number.

Resolve "Add Integration Tests"

See merge request oilgas/ltfs/fiphoboserver!25

* separate directories for unit tests and integration tests
* text files directory for testing server functions
* module for s3 utility functions
* module for file comparison utility functions
* module for generating random keys and meta data
* handle server executable within tests
* basic test for PUT and GET
* PUT and GET test for zero-byte file
* add integration testing to CI
* correct Clang Tidy job
* PUT command supports optional meta data
* test for GETMD
* test that GET with bad key fails
* test that PUT with used key fails

Resolve "CI"

See merge request oilgas/ltfs/fiphoboserver!22

* src/storage/phobos_file.hexplicit copy constructors to avoid double free of xd_objid
* tests: reflect meta data change to std::map from std::vector
* run Clang Format
* resolve Clang Tidy warnings
* add Gitlab-CI
* use fiphoboserver docker image
* update DockerHub image with Doxygen requirements
* CI: Clang Format job
* CI: Clang Tidy job
* CI: Doxygen build job
* CI: Unit Tests job

Cleanup codebase

See merge request oilgas/ltfs/fiphoboserver!20

Sophie Wenzel-Teuber authored Mar 31, 2020 and Aaron Dees committed Mar 31, 2020

Add a creation timestamp to the metadata and return only original Metadata in getmd (not the server related stuff)

Resolve "Add Unit Tests"

See merge request oilgas/ltfs/fiphoboserver!17

* utility functions for tests (utils.h, utils.cc)
* copy test text files to test binary directory during build
* tests for Phobos_file constructors
* tests for Phobos_file PUT and GET
* Phobos_file PUT and GET tests for empty file
* Phobos_file GETMD test
* in-memory (disk) storage solution for testing stream objects
* Fifo file descriptors must be copied explicitly as they are now an array
* Fifo tests for PUT and GET
* repeat Fifo tests for empty file
* Fifo tests for GETMD
* tests for Fifo object construction
* need to determine file size before db_get
* Phobos_file PUT  test for bad file descriptor exception
* Phobos_file PUT test for used object_id exception
* Phobos_file GETMD test for bad object_id
* Phobos_file GET test for bad object_id
* meta data is only written upon PUT operation in disk storage

Fix a documentation build issue: Now builds correctly without documentation enabled (Cmake variable CUSTOM_DOCU_PATH)

This reverts commit 1c7a83c1

Minor Code Improvements

See merge request oilgas/ltfs/fiphoboserver!19

Documentation

See merge request oilgas/ltfs/fiphoboserver!13

Resolve "Add Clang-Tidy"

See merge request oilgas/ltfs/fiphoboserver!16

Change log:
* use std::move to return from get_meta_data
* Fifo::put: replace Folly object argument with void pointer and size_t as arguments and return ssize_t
* Fifo::put considers rc < count to be an exception
* run Clang Tidy
* rename i_ps to IPs in main.cc

Resolve "Get Meta Data"

See merge request oilgas/ltfs/fiphoboserver!11

Change log:
* Send bad message upon entering unsupported request handler
* add c++ wrapper for pho_attrs_foreach
* Phobos_file::get_meta_data returns vector of key-value pairs
* Phobos_file::get_meta_data functions like:
* phobos_getmd_cpp fills the descriptor with attributes for the requested object
* phobos_attrs_foreach_cpp loops over the attrs and returns them to the stream
* Fifo::get_meta_data simply passes on the result of the storage call
* Fifo::get_meta_data returns vector of key-value pairs
* add Getmd request handler
* add getmd_request_handler.h to headers
* request handler has a meta_data member variable
* fill meta_data variable with Phobos attributes
* use repeated calls to ResponseBuilder.header to fill header with Phobos attributes
* send entire message at once
* add support for testing getmd